pump/: Fix block at wait for MaxCommitTS when offline #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when offline: 1, ApplyAction change statue to be closing, reject write but accept fake binlog 2, commitStatus() -> waitSafeToOffline(), we will write a fake binlog and wait when storage.MaxCommitTS() >= commit ts of the fake binlog ... after 1, may having some unwritten c-binlog(we will reject the write request from tidb), and in sorter, block at s.cond.Wait case because no more any item push.
|
/run-all-tests |
suzaku
reviewed
Aug 6, 2019
|
/run-all-tests |
suzaku
reviewed
Aug 7, 2019
suzaku
reviewed
Aug 7, 2019
|
/run-all-tests |
|
/run-all-tests |
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
Aug 7, 2019
* pump/: Fix block at wait for MaxCommitTS when offline when offline: 1, ApplyAction change statue to be closing, reject write but accept fake binlog 2, commitStatus() -> waitSafeToOffline(), we will write a fake binlog and wait when storage.MaxCommitTS() >= commit ts of the fake binlog ... after 1, may having some unwritten c-binlog(we will reject the write request from tidb), and in sorter, block at s.cond.Wait case because no more any item push.
IANTHEREAL
pushed a commit
that referenced
this pull request
Aug 8, 2019
* pump/: Fix block at wait for MaxCommitTS when offline when offline: 1, ApplyAction change statue to be closing, reject write but accept fake binlog 2, commitStatus() -> waitSafeToOffline(), we will write a fake binlog and wait when storage.MaxCommitTS() >= commit ts of the fake binlog ... after 1, may having some unwritten c-binlog(we will reject the write request from tidb), and in sorter, block at s.cond.Wait case because no more any item push.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
when offline:
1, ApplyAction change statue to be closing, reject write but accept fake
binlog
2, commitStatus() -> waitSafeToOffline(), we will write a fake binlog
and wait when storage.MaxCommitTS() >= commit ts of the fake binlog
...
after 1, may having some unwritten c-binlog(we will reject the write
request from tidb), and in sorter, block at s.cond.Wait case because no
more any item push.
What is changed and how it works?
only reject p-binlog when not online, and signal to wait up in sorter period.
Check List
Tests
offline pump when write qps = 10k
Code changes
Side effects
Related changes